Skip to content

build: only run commit message checks on PRs #20698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 2, 2020
Merged

build: only run commit message checks on PRs #20698

merged 1 commit into from
Oct 2, 2020

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Oct 1, 2020

Splits out the commit message check so it only runs against pull requests. If an invalid commit has made it into the main branch, we can't do much about it anymore so the failure generates unnecessary noise.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Oct 1, 2020
@crisbeto crisbeto requested a review from a team as a code owner October 1, 2020 07:30
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 1, 2020
josephperrott
josephperrott reviewed Oct 1, 2020
View reviewed changes
@crisbeto
build: only run commit message checks on PRs
8508f15 
Splits out the commit message check so it only runs against pull requests. If an invalid
commit has made it into the main branch, we can't do much about it anymore so
the failure generates unnecessary noise.
@crisbeto crisbeto force-pushed the commit-message-check-pr branch from fd191b7 to 8508f15 Compare October 1, 2020 20:42
josephperrott
josephperrott approved these changes Oct 1, 2020
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker merge safe labels Oct 2, 2020
@mmalerba mmalerba merged commit 6842b3e into angular:master Oct 2, 2020
mmalerba pushed a commit that referenced this pull request Oct 2, 2020
@crisbeto @mmalerba
build: only run commit message checks on PRs (#20698)
6ea851a 
Splits out the commit message check so it only runs against pull requests. If an invalid
commit has made it into the main branch, we can't do much about it anymore so
the failure generates unnecessary noise.

(cherry picked from commit 6842b3e)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josephperrott josephperrott josephperrott approved these changes

Assignees

@josephperrott josephperrott

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @josephperrott @googlebot @mmalerba