fix(material/menu): getLabel not working if text is inside indirect descendant node #20705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
20200/menu-get-label
branch
from
eb7eb8a to
67c123d
Compare
…escendant node Currently `MatMenuItem.getLabel` only looks at direct descendant text nodes in order to figure out its text while excluding things like icons. This breaks down if there's some kind of wrapper in the menu item. These changes fix the issue by using `textContent` and excluding icons specifically. Fixes angular#20200.
crisbeto
force-pushed
the
20200/menu-get-label
branch
from
67c123d to
15cb366
Compare
annieyw
pushed a commit
that referenced
this pull request
Oct 16, 2020
…escendant node (#20705) Currently `MatMenuItem.getLabel` only looks at direct descendant text nodes in order to figure out its text while excluding things like icons. This breaks down if there's some kind of wrapper in the menu item. These changes fix the issue by using `textContent` and excluding icons specifically. Fixes #20200. (cherry picked from commit a461929)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
MatMenuItem.getLabelonly looks at direct descendant text nodes in order to figure out its text while excluding things like icons. This breaks down if there's some kind of wrapper in the menu item.These changes fix the issue by using
textContentand excluding icons specifically.Fixes #20200.