Skip to content

Restore commit messages on failures #20707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 8, 2020
Merged

Restore commit messages on failures #20707

merged 2 commits into from
Oct 8, 2020

Conversation

josephperrott
Copy link
Member

See individual commits

@josephperrott josephperrott added target: patch This PR is targeted for the next patch release area: build & ci Related the build and CI infrastructure of the project labels Oct 2, 2020
@josephperrott josephperrott requested a review from jelbourn October 2, 2020 19:46
@josephperrott josephperrott requested a review from a team as a code owner October 2, 2020 19:46
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 2, 2020
crisbeto
crisbeto approved these changes Oct 3, 2020
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but you'll have to rebase to resolve the CI issues.

@josephperrott
build: add local ng-dev.user files to gitignore
72f40b0 
Allow for ng-dev.user local configuration to be established in individual's
repos.
@josephperrott
build: enable restoration of commit messages after failure
7023998 
When a commit message fails during validation, saves the commit message
draft and restores it on the next commit message attempt.
@josephperrott josephperrott force-pushed the restore-commit-messages branch from fa8390e to 7023998 Compare October 5, 2020 15:36
jelbourn
jelbourn approved these changes Oct 6, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added action: merge The PR is ready for merge by the caretaker merge safe labels Oct 6, 2020
@wagnermaciel wagnermaciel merged commit c9b7a1a into angular:master Oct 8, 2020
wagnermaciel pushed a commit that referenced this pull request Oct 8, 2020
@josephperrott @wagnermaciel
Restore commit messages on failures (#20707)
1bd0973 
* build: add local ng-dev.user files to gitignore

Allow for ng-dev.user local configuration to be established in individual's
repos.

* build: enable restoration of commit messages after failure

When a commit message fails during validation, saves the commit message
draft and restores it on the next commit message attempt.

(cherry picked from commit c9b7a1a)
@josephperrott josephperrott deleted the restore-commit-messages branch October 8, 2020 15:32
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@crisbeto crisbeto crisbeto approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@josephperrott @jelbourn @crisbeto @googlebot @wagnermaciel