Skip to content

fix(material/datepicker): don't handle escape key presses with modifier #20713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 7, 2020
Merged

fix(material/datepicker): don't handle escape key presses with modifier #20713

merged 1 commit into from
Oct 7, 2020

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Oct 3, 2020

Aligns the datepicker's escape key handling with the rest of the components where they aren't being handled if the user is pressing a modifier key.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Oct 3, 2020
@crisbeto crisbeto requested a review from mmalerba as a code owner October 3, 2020 18:30
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 3, 2020
@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Oct 4, 2020
mmalerba
mmalerba approved these changes Oct 4, 2020
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto
fix(material/datepicker): don't handle escape key presses with modifier
4b1bc1a 
Aligns the datepicker's escape key handling with the rest of the components where
they aren't being handled if the user is pressing a modifier key.
@crisbeto crisbeto force-pushed the datepicker-esc-key-modifiers branch from 13bbd04 to 4b1bc1a Compare October 5, 2020 15:06
@crisbeto crisbeto added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Oct 7, 2020
@wagnermaciel wagnermaciel merged commit 54f36a3 into angular:master Oct 7, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

Assignees

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @mmalerba @googlebot @wagnermaciel