Skip to content

docs(material/table): add multiTemplateDataRows specification #20748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2020
Merged

docs(material/table): add multiTemplateDataRows specification #20748

merged 1 commit into from
Oct 14, 2020

Conversation

geromegrignon
Copy link
Contributor

@geromegrignon geromegrignon commented Oct 8, 2020

Purpose

Add a section to material/table documentation about how to retrieve the index of a row when using the multiTemplateDataRows directive. This information is only accessible as a comment into the row.ts file of the cdk.


        Context provided to the row cells when multiTemplateDataRows is true. This context is the same
        as CdkCellOutletRowContext except that the single index value is replaced by dataIndex and
        renderIndex.


Motivation

Having notifications over time about a related issue i gave an answer 2 years ago.

Issue #12793

@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 8, 2020
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one minor comment.

@crisbeto crisbeto added docs This issue is related to documentation action: merge The PR is ready for merge by the caretaker merge safe target: patch This PR is targeted for the next patch release labels Oct 11, 2020
@annieyw annieyw merged commit 91a9355 into angular:master Oct 14, 2020
annieyw pushed a commit that referenced this pull request Oct 14, 2020
add a section about index

(cherry picked from commit 91a9355)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants