Skip to content

docs(getting-started): include a section about adding hammerjs to the config types #2076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 6, 2016

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Dec 4, 2016

Adds a section to the docs, mentioning that the user needs to add hammerjs to the tsconfig.json, in order to avoid some compilation errors.

Fixes #1944.

… config types

Adds a section to the docs, mentioning that the user needs to add `hammerjs` to the `tsconfig.json`, in order to avoid some compilation errors.

Fixes angular#1944.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 4, 2016
@clydin
Copy link
Member

clydin commented Dec 5, 2016

@clydin
Copy link
Member

clydin commented Dec 5, 2016

With the caveat of already having a types setting

@crisbeto
Copy link
Member Author

crisbeto commented Dec 5, 2016

It seems like it is, on our local demo test site we have the typeRoots everywhere, but it breaks if I remove the types setting.

@clydin
Copy link
Member

clydin commented Dec 6, 2016

Interesting. In my CLI-based projects I don't actually need either setting and I have a large amount of types installed.

@jelbourn
Copy link
Member

jelbourn commented Dec 6, 2016

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Dec 6, 2016
@clydin
Copy link
Member

clydin commented Dec 6, 2016

I looked at the demo app. tsc can resolve hammerjs after removing both typeRoots and types. (You will however get an error about a duplicate definition for "module"; @types/node defines it).
The issue appears to be the gulp typescript plugin.

@mmalerba mmalerba merged commit a1acf99 into angular:master Dec 6, 2016
@clydin
Copy link
Member

clydin commented Dec 6, 2016

Confirmed. Upgrading and integrating the latest gulp typescript plugin fixes the type resolution issue.
However, for material's repo structure and the large amount of gulp related @types, it would be better to leave the types setting in this case to restrict the included types to only hammerjs.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot find name 'HammerInput' and 'HammerManager'
5 participants