Skip to content

test(material-experimental/mdc-list): add missing test coverage #20771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2020

Conversation

crisbeto
Copy link
Member

Implements tests that were missing from the mdc-list package, as well as the mdc-checkbox, mdc-progress-spinner and mdc-snack-bar. The idea is that once we have parity on the test coverage, we can start to enforce test consistency automatically on the CI.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent merge safe target: patch This PR is targeted for the next patch release labels Oct 12, 2020
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 12, 2020
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn
Copy link
Member

Looks like a real failure on CI?

Implements tests that were missing from the `mdc-list` package, as well as
the `mdc-checkbox`, `mdc-progress-spinner` and `mdc-snack-bar`. The idea
is that once we have parity on the test coverage, we can start to enforce
test consistency automatically on the CI.
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Oct 13, 2020
@crisbeto
Copy link
Member Author

It was a real failure that should be resolved now.

@annieyw annieyw added target: minor This PR is targeted for the next minor release target: patch This PR is targeted for the next patch release and removed target: patch This PR is targeted for the next patch release target: minor This PR is targeted for the next minor release labels Oct 14, 2020
@annieyw annieyw merged commit 0909bc9 into angular:master Oct 14, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants