Skip to content

docs(material/input): add type="email" to input examples #20796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 20, 2020
Merged

docs(material/input): add type="email" to input examples #20796

merged 1 commit into from
Oct 20, 2020

Conversation

sAleksovski
Copy link
Contributor

Adds type="email" to examples in Overview and Examples page for inputs.

Fixes #20682

@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 14, 2020
@sAleksovski
docs(material/input): add type="email" to input examples
3969af3 
Adds type="email" to examples in Overview and Examples page for inputs.

Fixes angular#20682
crisbeto
crisbeto approved these changes Oct 15, 2020
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added docs This issue is related to documentation action: merge The PR is ready for merge by the caretaker merge safe target: patch This PR is targeted for the next patch release labels Oct 15, 2020
@jelbourn jelbourn merged commit b0e97af into angular:master Oct 20, 2020
jelbourn pushed a commit that referenced this pull request Oct 20, 2020
@sAleksovski @jelbourn
docs(material/input): add type="email" to input examples (#20796)
2594c0b 
Adds type="email" to examples in Overview and Examples page for inputs.

Fixes #20682

(cherry picked from commit b0e97af)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 20, 2020
@sAleksovski sAleksovski deleted the input-email-example branch November 20, 2020 20:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs-bug(Input): email examples don't use email type
3 participants
@sAleksovski @crisbeto @jelbourn