Skip to content

fix(material/autocomplete): options inside groups not read out with VoiceOver #20819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2020
Merged

fix(material/autocomplete): options inside groups not read out with VoiceOver #20819

merged 1 commit into from
Nov 4, 2020

Conversation

crisbeto
Copy link
Member

We're currently hitting a bug with mat-autocomplete that prevents options inside of mat-optgroup from being read out by VoiceOver on Safari. These changes implement an alternate accessibility pattern that only applies to options inside an autocomplete since the work correctly in mat-select.

@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround Accessibility This issue is related to accessibility (a11y) target: patch This PR is targeted for the next patch release labels Oct 16, 2020
@crisbeto crisbeto requested a review from jelbourn as a code owner October 16, 2020 19:57
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 16, 2020
@crisbeto crisbeto force-pushed the autocomplete-inert-groups branch from ef32f5d to 0c2350b Compare October 16, 2020 20:04
@jelbourn
Copy link
Member

I got confirmation from the original reporter of the issue that, as your observed, a recent update to either Chrome or macOS fixed the underlying issue for Chrome + VoiceOver. So, now the question becomes: do we break normal option group reading for Chrome to get options to do a workaround for Safari? I'm leaning slightly towards just leaving it as is and considering it a Safari issue.

@crisbeto
Copy link
Member Author

Without any data whatsoever, I was under the impression that most VoiceOver users are using it together with Safari which is still going to be broken. What if we limited the behavior from this PR to Safari with a TODO to eventually remove it, if it gets fixed in VoiceOver?

@jelbourn
Copy link
Member

Yeah, that seems reasonable, however unpalatable browser detection may be.

@crisbeto crisbeto force-pushed the autocomplete-inert-groups branch from 0c2350b to db17a75 Compare October 21, 2020 17:17
@crisbeto
Copy link
Member Author

Changed to only use the workaround on Safari.

jelbourn
jelbourn approved these changes Oct 23, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Oct 23, 2020
@crisbeto
fix(material/autocomplete): options inside groups not read out with V…
bb4f39a 
…oiceOver

We're currently hitting a bug with `mat-autocomplete` that prevents options inside of
`mat-optgroup` from being read out by VoiceOver on Safari. These changes implement
an alternate accessibility pattern that only applies to options inside an autocomplete
since the work correctly in `mat-select`.
@crisbeto crisbeto force-pushed the autocomplete-inert-groups branch from db17a75 to bb4f39a Compare October 30, 2020 15:31
@annieyw annieyw added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Nov 4, 2020
@annieyw annieyw merged commit 3866761 into angular:master Nov 4, 2020
@jelbourn jelbourn mentioned this pull request Nov 24, 2020
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crisbeto @jelbourn @annieyw