feat(material/slide-toggle): allow focus origin to be optional input in focus method #20913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
jesscxu
commented
Oct 28, 2020
| @@ -759,6 +762,15 @@ describe('MatSlideToggle with forms', () => { | |||
| expect(slideToggle.disabled).toBe(false); | |||
| expect(inputElement.disabled).toBe(false); | |||
| }); | |||
|
|
|||
| it('should not change focus origin if origin not specified', () => { | |||
| slideToggle.focus('mouse'); | |||
There was a problem hiding this comment.
Similar issue to here: #20912.
Would like to call focus on the button in the form, setting the origin to some value and then calling focus on slideToggle and expecting it to remain unchanged.
jesscxu
force-pushed
the
remove-default-origin-slide-toggle-focus
branch
from
a326702 to
d82fdb2
Compare
|
Linter throwing error stating my commit message is longer than 120 char, but it is not? |
mmalerba
reviewed
Oct 31, 2020
jesscxu
force-pushed
the
remove-default-origin-slide-toggle-focus
branch
2 times, most recently
from
19102ad to
472ff41
Compare
jesscxu
force-pushed
the
remove-default-origin-slide-toggle-focus
branch
from
472ff41 to
648f02a
Compare
annieyw
added
G
mmalerba
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT: For Angular Material components that have a focus() method, allow for the origin param to be optional and remove the default origin value.
WHY: For cases where the focus() method is called and the origin is already defined, we don’t want to override the origin using focusVia to always be some default value. In many cases, we want to leave the origin unchanged, but if there are cases that need the origin to be updated, allow for this with an optional origin param.