refactor(material-experimental/mdc-paginator): clean up theme sass

[mmalerba]

No description provided.

[crisbeto]

What exactly is broken in the dark theme? It seems to be working in the dev app.

[mmalerba]

Hmm you're right, I migrated an internal app I made and it was broken there. I might need to look more into what the difference was between that app and our dev app. (Though even if this change isn't necessary I'd still like to submit it as it cleans up the theme code a bit. There's no reason to transform the mat color config to an MDC one if we're not passing it to MDC's mixins

[mmalerba]

It was something wrong with the live reload setup, did a fresh rebuild and it was fine. That said I do think this is valuable cleanup so leaving it open

[jelbourn]

@mmalerba could you amend the commit to be more specific about the nature of the cleanup?

[crisbeto]

From what I can see, the change here is that we go through our own theming APIs instead of MDC's. I wrote the theme this way, because I was under the impression that we wanted to stick to MDC's theming API for the MDC-based components. We've been following a similar setup for all of the other ones under material-experimental.

[mmalerba]

We still want to rely on our themeing system, the mat-using-mdc-theme mixin temporarily plugs values from our theme into MDC's global variables. We only need to use that when we're calling out to MDC's mixins. Eventually I hope to get rid of it entirely, since MDC is moving toward a system that looks more like ours - one where you pass config objects around rather than rely on global variables

[mmalerba]

updated the commit message with more info

[jelbourn]

LGTM

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}