build: update to latest sass version #20984
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
google-cla
bot
added
the
cla: yes
crisbeto
commented
Nov 6, 2020
| + const result = sass.cli_pkg_main_0_(args); | ||
| + const originalThen = result.then$1$2$onError; | ||
| + let dynamicType; | ||
| + result.then$1$2$onError = (receiver, done, error, type) => dynamicType = type; |
There was a problem hiding this comment.
This is a very janky implementation, but the problem it's trying to solve is that then$1$2$onError requires an internal Dart type object to be passed in which we don't have access to. I hacked around it by monkey-patching the function, saving a reference and then passing it back in.
mmalerba
added
target: minor
|
@crisbeto needs rebase |
Bumps to the latest version of Sass and fixes up our custom patch so that it accounts for some changes in the published files.
|
Rebased. |
crisbeto
force-pushed
the
sass-1.29-upgrade
branch
from
0b4bf33 to
62ec78a
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps to the latest version of Sass and fixes up our custom patch so that it accounts for some changes in the published files.