Skip to content

fix(google-maps): info window not opening if no anchor is passed in #21014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 17, 2020
Merged

fix(google-maps): info window not opening if no anchor is passed in #21014

merged 1 commit into from
Nov 17, 2020

Conversation

crisbeto
Copy link
Member

Some time ago we added logic to prevent the info window from reopening if the same anchor is passed in. This ended up breaking the use case where a window is opened without an anchor, because the window always starts off without one.

Fixes #21013.

@crisbeto
fix(google-maps): info window not opening if no anchor is passed in
0b49d85 
Some time ago we added logic to prevent the info window from reopening if the same
anchor is passed in. This ended up breaking the use case where a window is opened
without an anchor, because the window always starts off without one.

Fixes angular#21013.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Nov 11, 2020
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 11, 2020
mmalerba
mmalerba approved these changes Nov 16, 2020
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Nov 16, 2020
@wagnermaciel wagnermaciel merged commit 17c357f into angular:master Nov 17, 2020
wagnermaciel pushed a commit that referenced this pull request Nov 17, 2020
@crisbeto @wagnermaciel
fix(google-maps): info window not opening if no anchor is passed in (#…
36cb325 
…21014)

Some time ago we added logic to prevent the info window from reopening if the same
anchor is passed in. This ended up breaking the use case where a window is opened
without an anchor, because the window always starts off without one.

Fixes #21013.

(cherry picked from commit 17c357f)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

Assignees

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(@angular/google-maps): Map Info Window isn't opened when call open() without params
3 participants
@crisbeto @mmalerba @wagnermaciel