Skip to content

fix(cdk/drag-drop): avoid retaining disabled handles after they've been destroyed #21015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 17, 2020
Merged

fix(cdk/drag-drop): avoid retaining disabled handles after they've been destroyed #21015

merged 1 commit into from
Nov 17, 2020

Conversation

crisbeto
Copy link
Member

The DragRef keeps track of which of its handles have been disabled, but if one of them is destroyed, we still keep its reference until the object is destroyed.

These changes add some extra logic to filter them out.

Fixes #21009.

@crisbeto
fix(cdk/drag-drop): avoid retaining disabled handles after they've be…
d914516 
…en destroyed

The `DragRef` keeps track of which of its handles have been disabled, but if one of
them is destroyed, we still keep its reference until the object is destroyed.

These changes add some extra logic to filter them out.

Fixes angular#21009.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Nov 11, 2020
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 11, 2020
@crisbeto crisbeto changed the title fix(cdk/drag-drop): avoid retaining disabled handles after they've be… fix(cdk/drag-drop): avoid retaining disabled handles after they've been destroyed Nov 11, 2020
@annieyw annieyw added the action: merge The PR is ready for merge by the caretaker label Nov 16, 2020
@wagnermaciel wagnermaciel merged commit de5a940 into angular:master Nov 17, 2020
wagnermaciel pushed a commit that referenced this pull request Nov 17, 2020
@crisbeto @wagnermaciel
fix(cdk/drag-drop): avoid retaining disabled handles after they've be…
7ab8a8e 
…en destroyed (#21015)

The `DragRef` keeps track of which of its handles have been disabled, but if one of
them is destroyed, we still keep its reference until the object is destroyed.

These changes add some extra logic to filter them out.

Fixes #21009.

(cherry picked from commit de5a940)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@annieyw annieyw annieyw approved these changes

Assignees

@annieyw annieyw

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(drag-drop): Destroying a disabled drag handle can leak memory
3 participants
@crisbeto @annieyw @wagnermaciel