Skip to content

fix(google-maps): server-side rendering error from map clusterer #21049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 24, 2020

Conversation

crisbeto
Copy link
Member

We have a guard around trying to initialize the clusterer on the server, but there's some more logic in ngAfterContentInit that will end up throwing if it hasn't been initialized.

Also adds a server-side rendering check.

We have a guard around trying to initialize the clusterer on the server, but there's
some more logic in `ngAfterContentInit` that will end up throwing if it hasn't been
initialized.

Also adds a server-side rendering check.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release labels Nov 14, 2020
@crisbeto crisbeto requested a review from devversion as a code owner November 14, 2020 10:16
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 14, 2020
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Nov 19, 2020
@annieyw annieyw merged commit 4a587a1 into angular:master Nov 24, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants