refactor(material-experimental/mdc-core): remove underscores from imported mixins #21060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P2
crisbeto
requested review from
andrewseguin,
devversion and
mmalerba
as code owners
google-cla
bot
added
the
cla: yes
crisbeto
force-pushed
the
mdc-underscored-styles
branch
from
a21e5ef to
591d96b
Compare
…orted mixins * Removes the underscores from the names of mixins that are used in other files. This will become an error when we switch to the Sass module system. * Renames some mixins that were starting with `mdc-` since they can be confused with mixins actually coming from MDC.
crisbeto
force-pushed
the
mdc-underscored-styles
branch
from
591d96b to
b507779
Compare
|
@crisbeto This causes our sync script to fail / not update some imports correctly. It's a little outside my expertise so I'm going to need to discuss with the team tomorrow. It'll try to get in an extra sync for this before the end of my caretaker rotation |
wagnermaciel
added
target: minor
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mdc-since they can be confused with mixins actually coming from MDC.