fix(cdk/drag-drop): preview not inheriting styles inside shadow dom #21107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default we create a drag preview by cloning the element and inserting the preview at the document root to avoid issues with `overflow: hidden`. The problem is that the clone won't look correctly if the host styles were encapsulated to the shadow DOM. These changes make it so that we insert the preview at the closest shadow root if the host is inside the shadow DOM, otherwise we fall back to the `body`.
crisbeto
added
P3
google-cla
bot
added
the
cla: yes
mmalerba
pushed a commit
that referenced
this pull request
Dec 4, 2020
…21107) By default we create a drag preview by cloning the element and inserting the preview at the document root to avoid issues with `overflow: hidden`. The problem is that the clone won't look correctly if the host styles were encapsulated to the shadow DOM. These changes make it so that we insert the preview at the closest shadow root if the host is inside the shadow DOM, otherwise we fall back to the `body`. (cherry picked from commit 5e5f87a)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default we create a drag preview by cloning the element and inserting the preview at the document root to avoid issues with
overflow: hidden. The problem is that the clone won't look correctly if the host styles were encapsulated to the shadow DOM.These changes make it so that we insert the preview at the closest shadow root if the host is inside the shadow DOM, otherwise we fall back to the
body.