Skip to content

docs: document global typography class prompt #21113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 24, 2020
Merged

docs: document global typography class prompt #21113

merged 1 commit into from
Nov 24, 2020

Conversation

djbrown
Copy link
Contributor

@djbrown djbrown commented Nov 22, 2020

add documentation for #17602

@djbrown djbrown requested a review from jelbourn as a code owner November 22, 2020 12:58
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 22, 2020
crisbeto
crisbeto reviewed Nov 22, 2020
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also it looks like the lint check for the commit message is failing. You can try changing it to:

docs: document global typography class prompt

@djbrown djbrown changed the title docs(Getting Started/install): document global typography class prompt docs: document global typography class prompt Nov 22, 2020
@djbrown
Copy link
Contributor Author

djbrown commented Nov 22, 2020

I fixed the typos as well as the commit and PR message

@djbrown djbrown requested a review from crisbeto November 22, 2020 14:26
crisbeto
crisbeto approved these changes Nov 22, 2020
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added docs This issue is related to documentation action: merge The PR is ready for merge by the caretaker merge safe target: patch This PR is targeted for the next patch release labels Nov 22, 2020
@annieyw annieyw merged commit 2c29265 into angular:master Nov 24, 2020
annieyw pushed a commit that referenced this pull request Nov 24, 2020
@djbrown @annieyw
docs: document global typography class prompt (#21113)
aac4300 
add documentation for #17602

(cherry picked from commit 2c29265)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@djbrown @crisbeto @annieyw