Skip to content

docs: fix css class in custom form field control guide #21206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 3, 2020
Merged

docs: fix css class in custom form field control guide #21206

merged 1 commit into from
Dec 3, 2020

Conversation

jeripeierSBB
Copy link
Contributor

See

components/src/material/form-field/form-field.ts

Line 323 in c68791d

this._elementRef.nativeElement.classList.add(`mat-form-field-type-${control.controlType}`);

@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 3, 2020
@jeripeierSBB jeripeierSBB changed the title docs: correct css class in custom form field control guide docs: fix css class in custom form field control guide Dec 3, 2020
jelbourn
jelbourn approved these changes Dec 3, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though the commit message is failing the lint check due to the line length limit

@jelbourn jelbourn added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release merge safe docs This issue is related to documentation labels Dec 3, 2020
@mmalerba mmalerba added the merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed label Dec 3, 2020
@mmalerba mmalerba merged commit e8ae494 into angular:master Dec 3, 2020
mmalerba pushed a commit that referenced this pull request Dec 3, 2020
@jeripeierSBB @mmalerba
docs: fix css class in custom form field control guide (#21206)
a3ba57d 
See https://github.com/angular/components/blob/c68791db9a0b4107d04fa924c27a087cd00a8989/src/material/form-field/
form-field.ts#L323

(cherry picked from commit e8ae494)
@jeripeierSBB
Copy link
Contributor Author

@jelbourn
I'm sorry, I was just about to fix the commit message, but you were faster ;-). Thanks for merging.

@jelbourn
Copy link
Member

jelbourn commented Dec 4, 2020

FWIW this PR prompted me to start a discussion about that line length and we're going to remove it (looks like it was really supposed to be just the commit header that had a length max)

@jeripeierSBB jeripeierSBB deleted the patch-1 branch December 4, 2020 06:41
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeripeierSBB @jelbourn @mmalerba