Skip to content

fix(material-experimental/mdc-table): Fix sticky scrolling #21211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 4, 2020
Merged

fix(material-experimental/mdc-table): Fix sticky scrolling #21211

merged 1 commit into from
Dec 4, 2020

Conversation

kseamon
Copy link
Collaborator

@kseamon kseamon commented Dec 3, 2020

Also adds some demos that show it working and how to work around some of the other
style differences from the original MatTable.

@kseamon
fix(material-experimental/mdc-table): Fix sticky scrolling
ce4b091 
Also adds some demos that show it working and how to work around some of the other
style differences from the original MatTable.
@kseamon kseamon requested a review from andrewseguin as a code owner December 3, 2020 23:05
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 3, 2020
@kseamon kseamon requested a review from jelbourn December 3, 2020 23:06
jelbourn
jelbourn approved these changes Dec 4, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added G This is is related to a Google internal issue action: merge The PR is ready for merge by the caretaker P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release labels Dec 4, 2020
@mmalerba mmalerba merged commit b6be078 into angular:master Dec 4, 2020
mmalerba pushed a commit that referenced this pull request Dec 4, 2020
@kseamon @mmalerba
fix(material-experimental/mdc-table): Fix sticky scrolling (#21211)
ceb0066 
Also adds some demos that show it working and how to work around some of the other
style differences from the original MatTable.

(cherry picked from commit b6be078)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement G This is is related to a Google internal issue P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kseamon @jelbourn @mmalerba