-
Notifications
You must be signed in to change notification settings - Fork 6.8k
build: update to latest Angular version and TypeScript 4.1 #21238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7aa6661
to
c0c4d0b
Compare
c0c4d0b
to
5fd838f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
These tests are failing due to:
Which seems to be coming from https://github.com/angular/angular/blob/b08fd0c18c131917577fc4c952c3d9f42b1e54fa/packages/compiler/src/output/output_jit_trusted_types.ts#L131 And the test fail when executing on Chrome 83. I wonder if this version of Chrome has an incomplete implementation of trusted types or something. @bjarkler can you please weigh in? @crisbeto you could also try to update the chrome version to 87. |
This is indeed due to a browser bug. Specifically, calling |
a9e9f54
to
5c53619
Compare
Thank you for looking into it @IgorMinar @bjarkler. It looks like what was happening was that Browserstack was identifying the Chromium-based Edge 83 as Chrome 83 which threw me off, because my assumption was that we were always testing against the latest version of Chrome. Bumping it up to 87 resolved the issue. Unblocking the PR now. |
Updates to the latest versions of Angular and TypeScript.
5c53619
to
a0db9dd
Compare
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Updates to the latest versions of Angular and TypeScript.
Note: I'm assuming that this is merge safe, because the framework is on TS 4.1 already.