fix(cdk/drag-drop): account for enterPredicate when setting receiving class #21346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… class Currently we set a class when a container is able to receive the dragged item, however we add this class to all connected containers without accounting for other things that could prevent the item from entering, like `enterPredicate`. These changes add some logic to account for the predicate when setting the class. Fixes angular#21171.
crisbeto
added
P3
google-cla
bot
added
the
cla: yes
crisbeto
commented
Dec 14, 2020
| @@ -4483,33 +4483,6 @@ describe('CdkDrag', () => { | |||
| expect(spy).toHaveBeenCalledWith(dragItem, dropInstances[1]); | |||
| })); | |||
|
|
|||
| it('should not call the `enterPredicate` if the pointer is not over the container', | |||
There was a problem hiding this comment.
This test was removed, because it's conflicting with what we want to do.
mmalerba
pushed a commit
that referenced
this pull request
Dec 17, 2020
… class (#21346) Currently we set a class when a container is able to receive the dragged item, however we add this class to all connected containers without accounting for other things that could prevent the item from entering, like `enterPredicate`. These changes add some logic to account for the predicate when setting the class. Fixes #21171. (cherry picked from commit 411b174)
wagnermaciel
pushed a commit
to wagnermaciel/components
that referenced
this pull request
Jan 14, 2021
… class (angular#21346) Currently we set a class when a container is able to receive the dragged item, however we add this class to all connected containers without accounting for other things that could prevent the item from entering, like `enterPredicate`. These changes add some logic to account for the predicate when setting the class. Fixes angular#21171.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we set a class when a container is able to receive the dragged item, however we add this class to all connected containers without accounting for other things that could prevent the item from entering, like
enterPredicate.These changes add some logic to account for the predicate when setting the class.
Fixes #21171.