Skip to content

docs(material/slider): updated slider documentation. #21395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 7, 2021
Merged

docs(material/slider): updated slider documentation. #21395

merged 1 commit into from
Jan 7, 2021

Conversation

DuncanFaulkner
Copy link
Contributor

In the tick marks section of the slider the word between is repeated.

@DuncanFaulkner
docs(material/slider): updated slider documentation to remove duplica…
65ee1fa 
…te word. In the tick marks section of the slider the word between is repeated.
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 18, 2020
crisbeto
crisbeto approved these changes Dec 19, 2020
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Caretaker note: this PR has the issue as some of the others where the CI didn't start. It's only docs changes so it shouldn't cause any issues.

@crisbeto crisbeto added merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note docs This issue is related to documentation action: merge The PR is ready for merge by the caretaker merge safe target: patch This PR is targeted for the next patch release labels Dec 19, 2020
@annieyw annieyw merged commit fee967e into angular:master Jan 7, 2021
annieyw pushed a commit that referenced this pull request Jan 7, 2021
@DuncanFaulkner @annieyw
docs(material/slider): updated slider documentation to remove duplica…
e0e01bb 
…te word. In the tick marks section of the slider the word between is repeated. (#21395)

(cherry picked from commit fee967e)
@DuncanFaulkner DuncanFaulkner deleted the slider-branch branch January 8, 2021 19:32
wagnermaciel pushed a commit to wagnermaciel/components that referenced this pull request Jan 14, 2021
@DuncanFaulkner @wagnermaciel
docs(material/slider): updated slider documentation to remove duplica…
4a1831a 
…te word. In the tick marks section of the slider the word between is repeated. (angular#21395)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DuncanFaulkner @crisbeto @annieyw