Skip to content

docs(material/icon): add harness example for icon #21406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 6, 2021
Merged

docs(material/icon): add harness example for icon #21406

merged 1 commit into from
Jan 6, 2021

Conversation

annieyw
Copy link
Contributor

@annieyw annieyw commented Dec 21, 2020

No description provided.

@annieyw annieyw added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent docs This issue is related to documentation merge safe target: patch This PR is targeted for the next patch release labels Dec 21, 2020
@annieyw annieyw requested review from jelbourn and mmalerba December 21, 2020 04:04
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 21, 2020
@annieyw annieyw force-pushed the icon-harness-example branch from 5ee38db to e81694e Compare December 21, 2020 04:38
crisbeto
crisbeto approved these changes Dec 21, 2020
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can be marked as ready when the lint failure is fixed.

@annieyw annieyw force-pushed the icon-harness-example branch from e81694e to bdda218 Compare December 21, 2020 08:11
@annieyw annieyw requested a review from devversion as a code owner December 21, 2020 08:11
@annieyw annieyw added the action: merge The PR is ready for merge by the caretaker label Dec 21, 2020
jelbourn
jelbourn approved these changes Dec 21, 2020
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@annieyw annieyw force-pushed the icon-harness-example branch from bdda218 to 8990179 Compare December 22, 2020 02:09
crisbeto
crisbeto approved these changes Dec 22, 2020
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but removing the "merge ready" label due to the two comments above. Can be set to "merge ready" again once they've been resolved.

@crisbeto crisbeto removed the action: merge The PR is ready for merge by the caretaker label Dec 22, 2020
@annieyw annieyw force-pushed the icon-harness-example branch from 8990179 to 5cee10c Compare December 22, 2020 08:18
@annieyw annieyw added the action: merge The PR is ready for merge by the caretaker label Dec 22, 2020
@annieyw annieyw merged commit 704c4be into angular:master Jan 6, 2021
annieyw added a commit that referenced this pull request Jan 6, 2021
@annieyw
docs(material/icon): add harness example for icon (#21406)
af1f478 
(cherry picked from commit 704c4be)
@annieyw annieyw deleted the icon-harness-example branch January 6, 2021 11:47
wagnermaciel pushed a commit to wagnermaciel/components that referenced this pull request Jan 14, 2021
@annieyw @wagnermaciel
docs(material/icon): add harness example for icon (angular#21406)
2d17c2a
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@crisbeto crisbeto crisbeto approved these changes

@mmalerba mmalerba Awaiting requested review from mmalerba

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

@devversion devversion Awaiting requested review from devversion

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@annieyw @jelbourn @crisbeto