Skip to content

fix(cdk/tree): Overflowing inline-code markup in readme #21426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 15, 2021

Conversation

marvinderksen
Copy link

No description provided.

@google-cla
Copy link

google-cla bot commented Dec 23, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla label Dec 23, 2020
Copy link
Contributor

@andrewseguin andrewseguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but your commit needs to match the style docs: fix overflowing inline-code markup in tree readme

@andrewseguin andrewseguin added action: merge The PR is ready for merge by the caretaker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent labels Jan 8, 2021
@marvinderksen
Copy link
Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Jan 8, 2021
@marvinderksen marvinderksen changed the title fix(cdk/tree): Overflowing inline-code markup in readme docs: fix overflowing inline-code markup in tree readme Jan 8, 2021
@marvinderksen marvinderksen changed the title docs: fix overflowing inline-code markup in tree readme fix(cdk/tree): Overflowing inline-code markup in readme Jan 8, 2021
@andrewseguin andrewseguin added the merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed label Jan 8, 2021
@mmalerba mmalerba added merge safe target: patch This PR is targeted for the next patch release labels Jan 15, 2021
@mmalerba mmalerba merged commit 6a58161 into angular:master Jan 15, 2021
mmalerba pushed a commit that referenced this pull request Jan 15, 2021
mmalerba pushed a commit that referenced this pull request Jan 15, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants