Skip to content

refactor(material/core): remove unnecessary styles from mat-option #21432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 15, 2021
Merged

refactor(material/core): remove unnecessary styles from mat-option #21432

merged 1 commit into from
Jan 15, 2021

Conversation

crisbeto
Copy link
Member

We had an override to make the option ripple semi-transparent in high contrast mode. This hasn't been necessary for a while, because we've been setting display: none on all ripples for high contrast users.

@crisbeto
refactor(material/core): remove unnecessary styles from mat-option
6199bad 
We had an override to make the option ripple semi-transparent in high contrast mode.
This hasn't been necessary for a while, because we've been setting `display: none` on all
ripples for high contrast users.
@crisbeto crisbeto added P4 A relatively minor issue that is not relevant to core functions target: patch This PR is targeted for the next patch release labels Dec 24, 2020
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 24, 2020
mmalerba
mmalerba approved these changes Jan 5, 2021
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Jan 5, 2021
@mmalerba mmalerba merged commit f12f6c3 into angular:master Jan 15, 2021
mmalerba pushed a commit that referenced this pull request Jan 15, 2021
@crisbeto @mmalerba
refactor(material/core): remove unnecessary styles from mat-option (#…
433bfbe 
…21432)

We had an override to make the option ripple semi-transparent in high contrast mode.
This hasn't been necessary for a while, because we've been setting `display: none` on all
ripples for high contrast users.

(cherry picked from commit f12f6c3)
mmalerba pushed a commit that referenced this pull request Jan 15, 2021
@crisbeto @mmalerba
refactor(material/core): remove unnecessary styles from mat-option (#…
3eb016c 
…21432)

We had an override to make the option ripple semi-transparent in high contrast mode.
This hasn't been necessary for a while, because we've been setting `display: none` on all
ripples for high contrast users.

(cherry picked from commit f12f6c3)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

Assignees

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P4 A relatively minor issue that is not relevant to core functions target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crisbeto @mmalerba