Skip to content

fix(material/datepicker): remove scroll bar while animating in touch UI mode #21493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 9, 2021

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jan 5, 2021

The screen reader close button is rendered outside the dialog which seems to cause a scrollbar to be shown while the animation is running. These changes fix the issue by hiding the button while the dialog is animating.

Slowed down video for reference:
demo

…UI mode

The screen reader close button is rendered outside the dialog which seems to cause a
scrollbar to be shown while the animation is running. These changes fix the issue by
hiding the button while the dialog is animating.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Jan 5, 2021
@crisbeto crisbeto requested a review from mmalerba as a code owner January 5, 2021 09:35
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 5, 2021
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Jan 5, 2021
@annieyw annieyw merged commit 13aa359 into angular:master Jan 9, 2021
annieyw pushed a commit that referenced this pull request Jan 9, 2021
…UI mode (#21493)

The screen reader close button is rendered outside the dialog which seems to cause a
scrollbar to be shown while the animation is running. These changes fix the issue by
hiding the button while the dialog is animating.

(cherry picked from commit 13aa359)
wagnermaciel pushed a commit to wagnermaciel/components that referenced this pull request Jan 14, 2021
…UI mode (angular#21493)

The screen reader close button is rendered outside the dialog which seems to cause a
scrollbar to be shown while the animation is running. These changes fix the issue by
hiding the button while the dialog is animating.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants