Skip to content

fix(cdk/scrolling): Prevents NaN being returned as firstVisibleIndex. #21505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 9, 2021
Merged

fix(cdk/scrolling): Prevents NaN being returned as firstVisibleIndex. #21505

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/cdk/scrolling/fixed-size-virtual-scroll.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,8 @@ export class FixedSizeVirtualScrollStrategy implements VirtualScrollStrategy {
const viewportSize = this._viewport.getViewportSize();
const dataLength = this._viewport.getDataLength();
let scrollOffset = this._viewport.measureScrollOffset();
let firstVisibleIndex = scrollOffset / this._itemSize;
// Prevent NaN as result when dividing by zero.
let firstVisibleIndex = (this._itemSize > 0) ? scrollOffset / this._itemSize : 0;

// If user scrolls to the bottom of the list and data changes to a smaller list
if (newRange.end > dataLength) {
Expand Down