Skip to content

docs(material/tree): add a description of the when predicate #21545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 12, 2021
Merged

docs(material/tree): add a description of the when predicate #21545

merged 1 commit into from
Jan 12, 2021

Conversation

Splaktar
Copy link
Contributor

  • also update TODO comments since the related issue was closed as a duplicate,
    point to the new issue

The mat docs for this seem to loose some context
Screen Shot 2021-01-11 at 15 17 01

That is in the CDK docs
Screen Shot 2021-01-11 at 15 16 50

@Splaktar
docs(material/tree): add a description of the when predicate
f10380f 
- update TODO comments since issue was closed as a duplicate,
  point to the new issue
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 11, 2021
@Splaktar Splaktar added the target: patch This PR is targeted for the next patch release label Jan 11, 2021
jelbourn
jelbourn approved these changes Jan 11, 2021
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added action: merge The PR is ready for merge by the caretaker merge safe labels Jan 11, 2021
@mmalerba mmalerba merged commit bd88e64 into angular:master Jan 12, 2021
mmalerba pushed a commit that referenced this pull request Jan 12, 2021
@Splaktar @mmalerba
docs(material/tree): add a description of the when predicate (#21545)
1724031 
- update TODO comments since issue was closed as a duplicate,
  point to the new issue

(cherry picked from commit bd88e64)
@Splaktar Splaktar deleted the mat-tree-improve-docs branch January 12, 2021 18:24
wagnermaciel pushed a commit to wagnermaciel/components that referenced this pull request Jan 14, 2021
@Splaktar @wagnermaciel
docs(material/tree): add a description of the when predicate (angular…
f0a953b 
…#21545)

- update TODO comments since issue was closed as a duplicate,
  point to the new issue
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Splaktar @jelbourn @mmalerba