Skip to content

refactor(material-experimental/mdc-progress-bar): update mdc-progress-bar to be compatible with API changes in MDC #21599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 19, 2021

Conversation

mmalerba
Copy link
Contributor

Project import generated by Copybara.

@google-cla
Copy link

google-cla bot commented Jan 14, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla label Jan 14, 2021
@google-cla
Copy link

google-cla bot commented Jan 14, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link

google-cla bot commented Jan 14, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@mmalerba mmalerba changed the title Project import generated by Copybara. refactor(material-experimental/mdc-progress-bar): update mdc-progress-bar to be compatible with API changes in MDC Jan 14, 2021
@mmalerba mmalerba added cla: yes PR author has agreed to Google's Contributor License Agreement blocked This issue is blocked by some external factor, such as a prerequisite PR target: patch This PR is targeted for the next patch release merge safe merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Jan 14, 2021
@mmalerba
Copy link
Contributor Author

mmalerba commented Jan 14, 2021

Caretaker note: this PR should not be merged until after http://cl/351815658 goes in.

After that, update to the latest MDC canary and it should be merge safe

Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba requested a review from a team as a code owner January 19, 2021 20:26
@google-cla
Copy link

google-cla bot commented Jan 19, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Jan 19, 2021
Angular Material Team and others added 2 commits January 19, 2021 12:31
mdc-progress-bar to be compatible with API changes in MDC

PiperOrigin-RevId: 351815658
…rogress-bar to be compatible with API changes in MDC
@google-cla
Copy link

google-cla bot commented Jan 19, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@mmalerba mmalerba added cla: yes PR author has agreed to Google's Contributor License Agreement action: merge The PR is ready for merge by the caretaker and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla blocked This issue is blocked by some external factor, such as a prerequisite PR target: patch This PR is targeted for the next patch release labels Jan 19, 2021
@mmalerba mmalerba added the target: rc This PR is targeted for the next release-candidate label Jan 19, 2021
@mmalerba mmalerba merged commit 5d7ce50 into master Jan 19, 2021
mmalerba added a commit that referenced this pull request Jan 19, 2021
…-bar to be compatible with API changes in MDC (#21599)

* refactor(material-experimental/mdc-progress-bar): update
mdc-progress-bar to be compatible with API changes in MDC

PiperOrigin-RevId: 351815658

* fixup! refactor(material-experimental/mdc-progress-bar): update mdc-progress-bar to be compatible with API changes in MDC

Co-authored-by: Angular Material Team <[email protected]>
(cherry picked from commit 5d7ce50)
wagnermaciel pushed a commit to wagnermaciel/components that referenced this pull request Jan 20, 2021
…-bar to be compatible with API changes in MDC (angular#21599)

* refactor(material-experimental/mdc-progress-bar): update
mdc-progress-bar to be compatible with API changes in MDC

PiperOrigin-RevId: 351815658

* fixup! refactor(material-experimental/mdc-progress-bar): update mdc-progress-bar to be compatible with API changes in MDC

Co-authored-by: Angular Material Team <[email protected]>
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: rc This PR is targeted for the next release-candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants