fix(ci): analyze commits should scan complete commit range. #216
Conversation
googlebot
added
the
cla: yes
devversion
force-pushed
the
fix/ci-analyze-commit-range
branch
3 times, most recently
from
ad2ecbf to
b1b45b9
Compare
| @@ -16,15 +16,19 @@ var blocked_statements = [ | |||
| ]; | |||
There was a problem hiding this comment.
While you're at it, can you rename this file to forbidden-identifiers.js ?
There was a problem hiding this comment.
devversion
force-pushed
the
fix/ci-analyze-commit-range
branch
from
5afa3d4 to
48f8710
Compare
| var diff = child_process.execSync('git diff --unified=0 HEAD~1 ./src ./e2e').toString(); | ||
| var isInvalid = blockedRegex.test(diff); | ||
| var diff = child_process.execSync( | ||
| 'git diff --unified=0 ' + commit_range + ' ./src ./e2e' |
There was a problem hiding this comment.
I can do that, but I don't think it's really necessary, because a plain string concatenation is doing the same. Plus additionally it's compatible with older node versions.
There was a problem hiding this comment.
IMO it's fine. The CLI targets >= 4.5, I don't think Material2 should be compatible with anything older.
|
Good point on the branch feature thing. cc @hansl to take a look. |
devversion
force-pushed
the
fix/ci-analyze-commit-range
branch
from
48f8710 to
32b2cc3
Compare
devversion
force-pushed
the
fix/ci-analyze-commit-range
branch
from
32b2cc3 to
bd3bebe
Compare
|
LGTM, giving @hansl a change to chime in |
|
LGTM. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This fixes the CI, to use the complete commit range.