Skip to content

build: check tooling scripts for compilation errors #21604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 15, 2021

Conversation

crisbeto
Copy link
Member

A lot of the scripts under tools are only run manually which means that it's easy for compilation errors to slip by when dependencies are updated.

These changes add another CI check to ensure that the scripts compile.

@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 15, 2021
A lot of the scripts under `tools` are only run manually which means that it's easy for
compilation errors to slip by when dependencies are updated.

These changes add another CI check to ensure that the scripts compile.
@crisbeto crisbeto marked this pull request as ready for review January 15, 2021 15:36
@crisbeto crisbeto requested a review from a team as a code owner January 15, 2021 15:36
@crisbeto crisbeto added merge safe P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release labels Jan 15, 2021
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Jan 15, 2021
@mmalerba mmalerba added target: rc This PR is targeted for the next release-candidate and removed target: patch This PR is targeted for the next patch release labels Jan 15, 2021
@mmalerba mmalerba merged commit a567c64 into angular:master Jan 15, 2021
mmalerba pushed a commit that referenced this pull request Jan 15, 2021
A lot of the scripts under `tools` are only run manually which means that it's easy for
compilation errors to slip by when dependencies are updated.

These changes add another CI check to ensure that the scripts compile.

(cherry picked from commit a567c64)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: rc This PR is targeted for the next release-candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants