Skip to content

build: downgrade bazel dependencies #21610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 15, 2021
Merged

build: downgrade bazel dependencies #21610

merged 1 commit into from
Jan 15, 2021

Conversation

crisbeto
Copy link
Member

A couple of dependencies were updated incorrectly which causes build errors locally.

@crisbeto
build: downgrade bazel dependencies
11a19ea 
A couple of dependencies were updated incorrectly which causes build errors locally.
@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround merge safe target: patch This PR is targeted for the next patch release labels Jan 15, 2021
@crisbeto crisbeto requested a review from a team as a code owner January 15, 2021 21:03
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 15, 2021
josephperrott
josephperrott approved these changes Jan 15, 2021
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Jan 15, 2021
mmalerba
mmalerba approved these changes Jan 15, 2021
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added target: rc This PR is targeted for the next release-candidate and removed target: patch This PR is targeted for the next patch release labels Jan 15, 2021
@mmalerba mmalerba merged commit 4ecdcb5 into angular:master Jan 15, 2021
mmalerba pushed a commit that referenced this pull request Jan 15, 2021
@crisbeto @mmalerba
build: downgrade bazel dependencies (#21610)
0611826 
A couple of dependencies were updated incorrectly which causes build errors locally.

(cherry picked from commit 4ecdcb5)
wagnermaciel pushed a commit to wagnermaciel/components that referenced this pull request Jan 20, 2021
@crisbeto @wagnermaciel
build: downgrade bazel dependencies (angular#21610)
f718b8a 
A couple of dependencies were updated incorrectly which causes build errors locally.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josephperrott josephperrott josephperrott approved these changes

@mmalerba mmalerba mmalerba approved these changes

Assignees

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: rc This PR is targeted for the next release-candidate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crisbeto @josephperrott @mmalerba