Skip to content

build: avoid multiple refreshes when running unit tests locally #2162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 13, 2016

Conversation

crisbeto
Copy link
Member

Avoids Karma running tests multiple times when developing locally, due to it triggering a test run whenever a new file is written to disk. This change switches to manually spawning a Karma server and then running the tests by depending on Gulp's API instead.

For reference, here's what running tests on master looks like:
old

And here's what it looks like with the new changes:
new

@crisbeto crisbeto requested a review from jelbourn December 10, 2016 20:45
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 10, 2016
@jelbourn
Copy link
Member

LGTM

I tried it out, way way better. Thanks!

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Dec 12, 2016
@jelbourn
Copy link
Member

@crisbeto can you rebase?

@jelbourn jelbourn added pr: needs rebase and removed action: merge The PR is ready for merge by the caretaker labels Dec 13, 2016
Avoids Karma running tests multiple times when developing locally, due to it triggering a test run whenever a new file is written to disk. This change switches to manually spawning a Karma server and then running the tests by depending on Gulp's API instead.
@crisbeto
Copy link
Member Author

Done @jelbourn.

@jelbourn jelbourn merged commit 66c25be into angular:master Dec 13, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants