Skip to content

refactor(material/sort): remove deprecated APIs for v12 #21833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 6, 2021

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Feb 7, 2021

Cleans up the deprecated APIs that were marked for removal in v12.

BREAKING CHANGES:

  • MatSortHeaderIntl.sortButtonLabel has been removed.
  • MatSortHeaderHarness.getAriaLabel has been removed.

@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release labels Feb 7, 2021
@crisbeto crisbeto added this to the 12.0.0 milestone Feb 7, 2021
@crisbeto crisbeto requested review from andrewseguin and a team as code owners February 7, 2021 14:05
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 7, 2021
@crisbeto crisbeto force-pushed the sort-v12-breaking-changes branch from 363ea1e to 5ec78c7 Compare February 7, 2021 14:09
@andrewseguin andrewseguin added the action: merge The PR is ready for merge by the caretaker label Mar 23, 2021
@crisbeto crisbeto force-pushed the sort-v12-breaking-changes branch from 5ec78c7 to 5a6cced Compare March 23, 2021 15:35
@wagnermaciel
Copy link
Contributor

@crisbeto I think you need to update the API goldens

Cleans up the deprecated APIs that were marked for removal in v12.

BREAKING CHANGES:
* `MatSortHeaderIntl.sortButtonLabel` has been removed.
* `MatSortHeaderHarness.getAriaLabel` has been removed.
@crisbeto crisbeto force-pushed the sort-v12-breaking-changes branch from 5a6cced to b68ba4e Compare March 25, 2021 15:45
@crisbeto
Copy link
Member Author

Done.

@annieyw annieyw merged commit 1b639f5 into angular:master Apr 6, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants