Skip to content

refactor(cdk/table): change deprecated APIs for v12 #21877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 18, 2021

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Feb 11, 2021

Changes the APIs that were marked as deprecated for v12.

BREAKING CHANGES:

  • _viewRepeater, _coalescedStyleScheduler and _viewportRuler parameters of the CdkTable constructor are now required.
  • _coalescedStyleScheduler parameter of the StickyStyler constructor is now required.

@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release labels Feb 11, 2021
@crisbeto crisbeto added this to the 12.0.0 milestone Feb 11, 2021
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 11, 2021
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Feb 12, 2021
@crisbeto crisbeto force-pushed the table-12-breaking-changes branch from e13fe6a to 925474d Compare February 13, 2021 08:22
@crisbeto
Copy link
Member Author

I just realized that I forgot to remove the @Optional from the parameters that aren't optional anymore. Pushing another change now...

Changes the APIs that were marked as deprecated for v12.

BREAKING CHANGES:
* `_viewRepeater`, `_coalescedStyleScheduler` and `_viewportRuler`
parameters of the `CdkTable` constructor are now required.
* `_coalescedStyleScheduler` parameter of the `StickyStyler` constructor is now required.
@crisbeto crisbeto force-pushed the table-12-breaking-changes branch from 925474d to 3e5dfe1 Compare February 13, 2021 08:35
@andrewseguin andrewseguin merged commit 46ebbad into angular:master Feb 18, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants