Skip to content

fix(material-experimental/mdc-button): fix incomplete icon class targ… #21919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 18, 2021
Merged

fix(material-experimental/mdc-button): fix incomplete icon class targ… #21919

merged 1 commit into from
Feb 18, 2021

Conversation

annieyw
Copy link
Contributor

@annieyw annieyw commented Feb 16, 2021

…eting in styles

Fab styles only targeted mat-icon but the icon in a mdc-button can have material-icons class instead

@annieyw annieyw added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent G This is is related to a Google internal issue target: patch This PR is targeted for the next patch release labels Feb 16, 2021
@annieyw annieyw requested a review from andrewseguin February 16, 2021 09:57
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 16, 2021
@annieyw
Copy link
Contributor Author

annieyw commented Feb 16, 2021

FYI this change passes presubmit.
Also for the lint error can it just be suppressed or is directly targeting material-icons not the way to go?

crisbeto
crisbeto approved these changes Feb 16, 2021
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The lint rule for class names isn't super thorough so it doesn't resolve nested selectors. I think that you can safely disable it for the failing lines.

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Feb 16, 2021
mmalerba
mmalerba approved these changes Feb 16, 2021
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewseguin andrewseguin merged commit 334ae2a into angular:master Feb 18, 2021
andrewseguin pushed a commit that referenced this pull request Feb 18, 2021
@annieyw @andrewseguin
fix(material-experimental/mdc-button): fix incomplete icon class targ…
b18b483 
…eting in styles (#21919)

(cherry picked from commit 334ae2a)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@mmalerba mmalerba mmalerba approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

@jelbourn jelbourn Awaiting requested review from jelbourn

@wagnermaciel wagnermaciel Awaiting requested review from wagnermaciel

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement G This is is related to a Google internal issue P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@annieyw @crisbeto @mmalerba @andrewseguin