Skip to content

docs: mention entryComponents is no longer necessary #21972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2021

Conversation

AlexElin
Copy link
Contributor

@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 20, 2021
@AlexElin AlexElin force-pushed the correct_entryComponents_docs branch from d4ea10c to e237831 Compare February 20, 2021 10:28
@AlexElin AlexElin force-pushed the correct_entryComponents_docs branch from e237831 to 35b827d Compare February 20, 2021 18:52
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added docs This issue is related to documentation action: merge The PR is ready for merge by the caretaker merge safe target: patch This PR is targeted for the next patch release labels Feb 20, 2021
@dev054
Copy link

dev054 commented Feb 22, 2021

Comment on lines 53 to 54
**This is only necessary if your project is using ViewEngine. It doesn't have to be specified for
projects running on Ivy.**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would phrase this like

You only need to specify `entryComponents` if your project uses ViewEngine. Projects
using Angular Ivy don't need `entryComponents`.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

corrected
Also, I've updated a portal's docs as @dev054 suggested

@AlexElin AlexElin force-pushed the correct_entryComponents_docs branch from 35b827d to 68bf5af Compare February 23, 2021 09:08
@AlexElin AlexElin force-pushed the correct_entryComponents_docs branch from 68bf5af to 0a9aa84 Compare February 23, 2021 19:00
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants