docs(button): add icon button to readme #221
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
| @@ -42,7 +49,7 @@ Example: | |||
|
|
|||
| Output: | |||
|
|
|||
| <img src="https://material.angularjs.org/material2_assets/buttons/basic-buttons.png"> | |||
|  | |||
There was a problem hiding this comment.
Can you update the button asset here instead? Should be hosted from Material assets.
There was a problem hiding this comment.
Yeah, I wrote that in the description, but I will file a PR. Yes, will change it back.
There was a problem hiding this comment.
Ah, missed that. Yes, please change.
devversion
force-pushed
the
docs/icon-button
branch
from
7c3ac4b to
93ee45c
Compare
|
LGTM |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notice: The screenshot host has changed, since I can't change the screenshots in code.material.angularjs.org, but I think githubusercontent, is also good.