Skip to content

fix(material-experimental/mdc-select): correct some differences between #22108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 9, 2021
Merged

fix(material-experimental/mdc-select): correct some differences between #22108

merged 2 commits into from
Apr 9, 2021

Conversation

mmalerba
Copy link
Contributor

@mmalerba mmalerba commented Mar 3, 2021

mat-select and native select

fixes the native select arrow color and vertical alignment and removes extra padding from the mat-select arrow

@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 3, 2021
@mmalerba mmalerba added P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release labels Mar 3, 2021
wagnermaciel
wagnermaciel approved these changes Mar 4, 2021
View reviewed changes
Copy link
Contributor

@wagnermaciel wagnermaciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

crisbeto
crisbeto approved these changes Mar 4, 2021
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added the action: merge The PR is ready for merge by the caretaker label Mar 4, 2021
@annieyw
Copy link
Contributor

annieyw commented Apr 1, 2021

@mmalerba needs rebase

@mmalerba mmalerba added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Apr 9, 2021
@mmalerba mmalerba merged commit 10cc9cf into angular:master Apr 9, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@annieyw annieyw annieyw left review comments

@crisbeto crisbeto crisbeto approved these changes

@wagnermaciel wagnermaciel wagnermaciel approved these changes

@devversion devversion Awaiting requested review from devversion

Assignees

@annieyw annieyw

@wagnermaciel wagnermaciel

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mmalerba @annieyw @crisbeto @wagnermaciel