Skip to content

fix(material/progress-bar): adjust buffer colors #22164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 10, 2021
Merged

fix(material/progress-bar): adjust buffer colors #22164

merged 2 commits into from
Mar 10, 2021

Conversation

andrewseguin
Copy link
Contributor

Fixes #22130

BEFORE:

Screen Shot 2021-03-09 at 10 26 31 AM
Screen Shot 2021-03-09 at 10 26 42 AM

AFTER:

Screen Shot 2021-03-09 at 10 23 10 AM
Screen Shot 2021-03-09 at 10 23 00 AM

@andrewseguin andrewseguin added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Mar 9, 2021
@andrewseguin andrewseguin requested a review from crisbeto March 9, 2021 17:28
@andrewseguin andrewseguin requested a review from jelbourn as a code owner March 9, 2021 17:28
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 9, 2021
@andrewseguin andrewseguin mentioned this pull request Mar 9, 2021
Closed
crisbeto
crisbeto approved these changes Mar 9, 2021
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewseguin
Copy link
Contributor Author

andrewseguin commented Mar 9, 2021 •
edited
Loading

Bummer, it's not going to like the solution when the user has variables. I suspect we'll have to fallback to the legacy approach if variables are involved.

Edit: Fixed by verifying that the theme and background colors are not variables

@andrewseguin andrewseguin added action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Mar 10, 2021
@mmalerba mmalerba added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Mar 10, 2021
@mmalerba mmalerba merged commit 94d5850 into angular:master Mar 10, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(mat-progress-bar): Buffer bar slightly lighter than expected
3 participants
@andrewseguin @crisbeto @mmalerba