build: avoid installing node-sass #22283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We no longer use `node-sass`, but we were still installing it, because `gulp-sass` depends upon it. These changes switch to a fork of `gulp-sass` that depends on the Dart version of Sass.
crisbeto
added
P3
google-cla
bot
added
the
cla: yes
Splaktar
approved these changes
Mar 18, 2021
There was a problem hiding this comment.
It looks like https://www.npmjs.com/package/gulp-dart-sass is getting some good usage and installation growth, but it's too bad that the repo hasn't been updated since October and doesn't accept issues (only PRs).
It's good to get off of node-sass for sure, but it isn't clear that this new package will be something that we can rely upon long-term.
|
Needs rebase to get it into 11.2.x |
andrewseguin
added
target: minor
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer use
node-sass, but we were still installing it, becausegulp-sassdepends upon it. These changes switch to a fork ofgulp-sassthat depends on the Dart version of Sass.