build: schematics unit tests not being run #22293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
Currently the schematics unit tests aren't being run and are assumed as passing. This was a result of the following issues: 1. The `require.resolve` call in the `index.spec.ts` files was failing, but it was inside of a `Promise` so it got silenced. It caused the test runner to completely give up on running the tests. I was only able to see the failure using a debugger. 2. Even if the `require.resolve` call worked as expected, the `filegroup` call doesn't seem to actually work, at least on Windows which would prevent the files from showing up in the Bazel directory. I've switched it to `copy_to_bin`. 3. There was some issue with loading the `index.spec.ts`, presumably because the file name follows the same pattern as unit test files. I've renamed it to `paths.ts` as a workaround.
crisbeto
force-pushed
the
schematics-test-fix
branch
from
fa467e3 to
63dcd3c
Compare
crisbeto
added
merge safe
P2
andrewseguin
pushed a commit
that referenced
this pull request
Mar 19, 2021
Currently the schematics unit tests aren't being run and are assumed as passing. This was a result of the following issues: 1. The `require.resolve` call in the `index.spec.ts` files was failing, but it was inside of a `Promise` so it got silenced. It caused the test runner to completely give up on running the tests. I was only able to see the failure using a debugger. 2. Even if the `require.resolve` call worked as expected, the `filegroup` call doesn't seem to actually work, at least on Windows which would prevent the files from showing up in the Bazel directory. I've switched it to `copy_to_bin`. 3. There was some issue with loading the `index.spec.ts`, presumably because the file name follows the same pattern as unit test files. I've renamed it to `paths.ts` as a workaround. (cherry picked from commit 263c90c)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the schematics unit tests aren't being run and are assumed as passing. This was a result
of the following issues:
require.resolvecall in theindex.spec.tsfiles was failing, but it was inside of aPromiseso it got silenced. It caused the test runner to completely give up on running the tests. I was only able to see the failure using a debugger.require.resolvecall worked as expected, thefilegroupcall doesn't seem to actually work, at least on Windows which would prevent the files from showing up in the Bazel directory. I've switched it tocopy_to_bin.index.spec.ts, presumably because the file name follows the same pattern as unit test files. I've renamed it topaths.tsas a workaround.