fix(cdk/text-field): autosize text areas using the placeholder #22308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug with CdkTextareaAutosize where the textarea would not be autosized when using long placeholders Fixes #22042 Cache the height with the placeholder do calculation better fix comment Stop caching the placeholder because I can't make the caching approach work with view-engine go back to the caching approach Account for the input tests fix lint error
google-cla
bot
added
the
cla: yes
|
This is a repeat of #22197 which was accidentally merged. This PR has failures in g3 and should not be merged yet |
|
I created #22314 which has the original changes + a fix |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug with CdkTextareaAutosize where the textarea would not be autosized when using long placeholders
Fixes #22042