Skip to content

docs(material/snack-bar): Fix typo in snackbar jsdoc. #22322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2021

Conversation

12wrigja
Copy link
Contributor

No description provided.

@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 24, 2021
@12wrigja
Copy link
Contributor Author

This typo looks like it's also present in various other repos in the Angular org - do I need to submit a PR for each of those or is there some automation that looks at this file as a source of truth?

https://github.com/search?q=org%3Aangular+applie&type=code

@crisbeto
Copy link
Member

All of these comments need to be fixed, but they can be done in this PR. Note that you'll have to change the commit message to start with docs(material/snack-bar) in order for the lint check to pass.

@12wrigja
Copy link
Contributor Author

12wrigja commented Apr 3, 2021

All of these comments need to be fixed, but they can be done in this PR.

Can you clarify? All the typos in that search (besides the one in snackbar.ts) are outside this git repo, so unless GH has some magic I'm unaware of they would all have to be separate PRs. Unless you meant that the fix within snackbar.ts is enough (and the others will get fixed as a result of this PR being merged)?

@jelbourn jelbourn added G This is is related to a Google internal issue action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Apr 7, 2021
@mmalerba
Copy link
Contributor

mmalerba commented Apr 9, 2021

The other ones are generated from the line you changed, they'll be fixed automatically

@mmalerba mmalerba changed the title docs(common): Fix typo in snackbar jsdoc. docs(material/snack-bar): Fix typo in snackbar jsdoc. Apr 9, 2021
@mmalerba mmalerba merged commit ce64f5e into angular:master Apr 9, 2021
mmalerba pushed a commit that referenced this pull request Apr 9, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement G This is is related to a Google internal issue target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants