feat(material/testing): MatChipHarness getAvatar #22348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
tamas-nemeth
force-pushed
the
chip-harness-get-avatar
branch
from
4132d43 to
fa489fc
Compare
crisbeto
reviewed
Mar 26, 2021
| @@ -22,6 +27,11 @@ export class MatChipHarness extends ComponentHarness { | |||
| static with<T extends typeof MatChipHarness>(this: T, options: ChipHarnessFilters = {}): | |||
| HarnessPredicate<InstanceType<T>> { | |||
| return new HarnessPredicate(MatChipHarness, options) | |||
| .addOption( | |||
| 'hasAvatar', | |||
| options.hasAvatar, | |||
There was a problem hiding this comment.
Is it that common of a use case to be able to query only chips that have an avatar? We don't have anything similar for the other icons that can be projected (e.g. the remove icon).
There was a problem hiding this comment.
it's probably not that common. removed
| /** | ||
| * Whether the chip has an avatar | ||
| */ | ||
| async hasAvatar() { |
There was a problem hiding this comment.
I don't think that we need this since it can be inferred from getAvatar.
There was a problem hiding this comment.
right, removed
tamas-nemeth
force-pushed
the
chip-harness-get-avatar
branch
from
fa489fc to
b6614c7
Compare
crisbeto
reviewed
Mar 28, 2021
tamas-nemeth
force-pushed
the
chip-harness-get-avatar
branch
from
b6614c7 to
6ec8ed9
Compare
tamas-nemeth
force-pushed
the
chip-harness-get-avatar
branch
from
6ec8ed9 to
373e5d3
Compare
|
rebased after conflicts |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MatChipAvatarHarnessgetAvatarmethod toMatChipHarnessMatChipHarnessextendContentContainerComponentHarnessMatIconHarnessinside a chip