fix(material/paginator): button icons blending in with background in high contrast mode on Chromium browsers #22385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
google-cla
bot
added
the
cla: yes
crisbeto
force-pushed
the
paginator-high-contrast
branch
2 times, most recently
from
023bb58 to
caefaa6
Compare
…high contrast mode on Chromium browsers Setting `fill: currentColor` on an SVG element causes it to blend in with the background on Chromium-based browsers. These changes add a fallback color.
crisbeto
force-pushed
the
paginator-high-contrast
branch
from
caefaa6 to
b583328
Compare
andrewseguin
approved these changes
Apr 9, 2021
andrewseguin
approved these changes
Apr 9, 2021
|
|
||
| // On Chromium browsers the `currentColor` blends in with the | ||
| // background for SVGs so we have to fall back to `CanvasText`. | ||
| fill: CanvasText; |
There was a problem hiding this comment.
Should there be a conditional here?
There was a problem hiding this comment.
There shouldn't, because some browsers don't support CanvasText.
wagnermaciel
added
target: minor
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting
fill: currentColoron an SVG element causes it to blend in with the background on Chromium-based browsers. These changes add a fallback color.