Skip to content

docs: add missing standards for building components #22412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 8, 2021

Conversation

wagnermaciel
Copy link
Contributor

  • Naming conventions for the selectors of components & directives
  • The tests & public APIs for MDC components should mirror the non-MDC version
  • Public properties should use coercion

@wagnermaciel wagnermaciel requested a review from a team as a code owner April 6, 2021 18:57
@wagnermaciel wagnermaciel requested a review from annieyw April 6, 2021 18:57
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 6, 2021
@wagnermaciel wagnermaciel added the target: patch This PR is targeted for the next patch release label Apr 6, 2021
@wagnermaciel wagnermaciel requested a review from crisbeto April 6, 2021 19:32
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@wagnermaciel wagnermaciel requested a review from jelbourn April 7, 2021 19:01
* Naming conventions for the selectors of components & directives
* The tests & public APIs for MDC components should mirror the non-MDC version
* Public properties should use coercion
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added docs This issue is related to documentation action: merge The PR is ready for merge by the caretaker merge safe labels Apr 7, 2021
@mmalerba mmalerba merged commit 60946cc into angular:master Apr 8, 2021
mmalerba pushed a commit that referenced this pull request Apr 8, 2021
* docs: add missing standards for building components

* Naming conventions for the selectors of components & directives
* The tests & public APIs for MDC components should mirror the non-MDC version
* Public properties should use coercion

* fixup! docs: add missing standards for building components

* fixup! docs: add missing standards for building components

* fixup! docs: add missing standards for building components

(cherry picked from commit 60946cc)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants