-
Notifications
You must be signed in to change notification settings - Fork 6.8k
docs: add missing standards for building components #22412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
wagnermaciel
commented
Apr 6, 2021
- Naming conventions for the selectors of components & directives
- The tests & public APIs for MDC components should mirror the non-MDC version
- Public properties should use coercion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
* Naming conventions for the selectors of components & directives * The tests & public APIs for MDC components should mirror the non-MDC version * Public properties should use coercion
29bdc6e
to
65894bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* docs: add missing standards for building components * Naming conventions for the selectors of components & directives * The tests & public APIs for MDC components should mirror the non-MDC version * Public properties should use coercion * fixup! docs: add missing standards for building components * fixup! docs: add missing standards for building components * fixup! docs: add missing standards for building components (cherry picked from commit 60946cc)
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |