docs(material/theming): rewrite elevation guide #22467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jelbourn
added
P2
google-cla
bot
added
the
cla: yes
crisbeto
approved these changes
Apr 13, 2021
guides/elevation.md
Outdated
| `$zValue` is number from 0 to 24, representing the semantic elevation of the element, that controls | ||
| the intensity of the box-shadow. You can use the `$color` and `$opacity` parameters to further | ||
| customize the shadow appearance. Because an elevation shadow consists of multiple shadow components | ||
| of varying opacities, the `$opacity` argument of the mixin acts as a factor by which to scale these |
There was a problem hiding this comment.
I think that we might want to not mention the opacity parameter since the MDC mixins don't support it. They have something like an "opacity boost" where it adds some opacity to the base.
jelbourn
force-pushed
the
rewrite-elevation
branch
from
c1f92cc to
2f5cf9b
Compare
twerske
approved these changes
Apr 14, 2021
| ### Overridable elevation | ||
|
|
||
| When authoring a component, you may want to specify a default elevation that the component consumer | ||
| can override. You can accomplish this by using the `overridable-elevation` Sass mixin. This behaves |
There was a problem hiding this comment.
[stretch] adding an example of the override to show this overridable usecase?
I'm not strongly opinionated on this
There was a problem hiding this comment.
I'll pass on this since I think it's kind of niche and also laziness.
jelbourn
added
target: rc
TeriGlover
approved these changes
Apr 19, 2021
|
Editing review complete; left a few suggestions.
…On Fri, Apr 16, 2021 at 4:22 PM Jeremy Elbourn ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In guides/elevation.md
<#22467 (comment)>:
> @@ -47,14 +44,23 @@ In order to use the mixin, you must import ***@***.***/material`:
}
```
-For convenience, you can use the `elevation-transition` mixin to add a transition when the
-elevation changes:
+### Overridable elevation
+
+When authoring a component, you may want to specify a default elevation that the component consumer
+can override. You can accomplish this by using the `overridable-elevation` Sass mixin. This behaves
I'll pass on this since I think it's kind of niche and also laziness.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#22467 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AR4DPGX2SX6LXRGIFSJPAPLTJDBDTANCNFSM422I3GSQ>
.
--
*--Teri Glover--*
*Technical Editor*
|
mmalerba
approved these changes
Apr 19, 2021
This change updates the elevation guide to be more clear, concise, and complete. The changes include: * Drop content about the general concept of elevation, deferring that to the Material Design spec. * Document the `overridable-elevation` mixin * Mention that the elevation CSS classes are emitted by `core-theme`. * Switch to `@use`
jelbourn
force-pushed
the
rewrite-elevation
branch
from
2f5cf9b to
d13274d
Compare
wagnermaciel
pushed a commit
that referenced
this pull request
Apr 21, 2021
This change updates the elevation guide to be more clear, concise, and complete. The changes include: * Drop content about the general concept of elevation, deferring that to the Material Design spec. * Document the `overridable-elevation` mixin * Mention that the elevation CSS classes are emitted by `core-theme`. * Switch to `@use` (cherry picked from commit 3e4e6d0)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the elevation guide to be more clear, concise, and
complete. The changes include:
the Material Design spec.
overridable-elevationmixincore-theme.@use