docs(cdk/a11y): update Sass docs for new theming API #22468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jelbourn
added
P2
google-cla
bot
added
the
cla: yes
crisbeto
approved these changes
Apr 13, 2021
| The `$target` parameter allows you to specify which variation of high contrast mode your style | ||
| targets. The accepted values are `active` (default), `black-on-white`, and `white-on-black`. These | ||
| values correspond to the supported values for the | ||
| [`-ms-high-contrast` media query][ms-high-contrast]. |
There was a problem hiding this comment.
Not sure whether we should mention the media query, because we wrap the selector with a class which behaves slightly differently when used together with Sass' &.
There was a problem hiding this comment.
I still want to mention it because it explains where the values come from
There was a problem hiding this comment.
Sure, I don't feel strongly against it.
twerske
reviewed
Apr 14, 2021
jelbourn
added
target: rc
TeriGlover
approved these changes
Apr 19, 2021
|
Editing review; a couple of suggestions, LGTM.
…On Wed, Apr 14, 2021 at 2:10 PM Emma Twersky ***@***.***> wrote:
***@***.**** approved this pull request.
lgtm!
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#22468 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AR4DPGUWPLHPCL4HELB64H3TIYACVANCNFSM422KKSQA>
.
--
*--Teri Glover--*
*Technical Editor*
|
This change updates the Sass documentation for cdk/a11y to reflect the new `@use`-based API. Additionally, it adds documentation for the parameters to `cdk.high-contrast`.
wagnermaciel
pushed a commit
that referenced
this pull request
Apr 21, 2021
This change updates the Sass documentation for cdk/a11y to reflect the new `@use`-based API. Additionally, it adds documentation for the parameters to `cdk.high-contrast`. (cherry picked from commit 2a9854e)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the Sass documentation for cdk/a11y to reflect the
new
@use-based API. Additionally, it adds documentation for theparameters to
cdk.high-contrast.